Changes in r672, suggesting improvement

[zboszor]

I saw r672 and the changes and I had to port it to TSconf. In TSconf, there are 3 more tracked keys already: Left Win, Right Win and Context Menu. Adding them overflows 8 bits in the kb_ctrl_status kb_ctrl_mapped, so a 2-byte array is needed for both functionality. To reduce the AVR code difference between Pentevo and TSconf, I created the attached patch. It also adds the 15th RTC register (may be an invalid change, I don't know) so the extra 3 key states are also exposed.

[lvd]

for you and co, profit is obvious. what is the profit for us to make your job easier?

[zboszor]

This patch simply adds the feature to read the LWIN, RWIN and MENU keys. As such, it's a generic feature that programs on the Pentevo can exploit. It's only a plus that it would be a common feature between the AVR code in BaseConf and TSconf with compatible bit layout in the RTC registers.

Perhaps this can be a bridge for restoring goodwill between the two camps, too. I know that I am an outsider and usually the outsider is beaten by both parties when speaking up in a skirmish. I am a hopeless dreamer.

[DimkaM]

I am a hopeless dreamer.

Используйте прямое чтение скан-кодов и ваши мечты сбудутся.

[zboszor]

Используйте прямое чтение скан-кодов и ваши мечты сбудутся.

Funny man. Your comment also implies that you don't agree with the Pentevo r672 change because these are duplicate features:

* - Add reading state of LCTRL,RCTRL,LALT,RALT,LSHIFT,RSHIFT,F12 keyboard states from RTC register D (bits 0-6).
* - Add reading state of NUM LOCK LED from RTC register C (bit 0).

They can be read via scancodes, too.

[DimkaM]

zboszor, если вы умеете программировать под avr и у вас есть свободное время, то попытайтесь избавить ZX-Evo от задержек при чтении регистров RTC.
Тогда я стану счастливым человеком. И многие скажут вам за это - спасибо.

[zboszor]

That's a good project, indeed. I know how to handle 0% CPU usage signalling from Linux, I hope I can tackle something using interrupts in AVR but don't hold your breath until I work it out.